Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1798
Tech-debt week continues ⛏️ 💰 🎉
This PR makes CI use node v8.9.4 and npm v5.6.0 (which works much better v3 😏 ). This CI image use Chrome 64 (i.e. the latest version) which should make it easier for us to make our tests run consistency locally and on CI.
Using npm5 gives us access to
package-lock.json
file (more info here) which contains a complete description of thenode_modules/
tree. Now,npm i
(should) give the same result everywhere everytime. This makes a few our tooling helpers obsolete:dist/npm-ls.json
is gone and no need todedupe
onpreversion
.A few more things:
eslint@4
(which runs a little faster now) andkarma@2
,check-node-version
now runs onpreversion
ensuring that whoever bundles thedist/
use node8 and npm5.cc @alexcjohnson @dfcreative @nicolaskruchten @monfera